[release/8.0-rc1] Fix NullableAttribute illink test failures #90680
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When we started building with preview 7 in 5549f72, NullableAttribute in these testcases started to use the attribute definition from the framework, instead of generating it into the code. This broke the `--used-attrs-only` optimization because `skip` assemblies (the default for the framework in these testcases) are treated as if all types in them are kept, for the purposes of the `--used-attrs-only` optimization. (The optimization removes attribute instances unless the attribute type is preserved for some other reason). It's not clear what the intended behavior of `--used-attrs-only` is for `skip` assemblies, and the discussion in dotnet/linker#952 indicates that it's considered experimental, so this fixes the failures by using the `link` action. This represents a more realistic scenario since `skip` is mainly used in testing to avoid linking the framework in every testcase.
ghost
added
the
linkable-framework
dotnet-issue-labeler
bot
added
the
needs-area-label
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsBackport of #90449 to release/8.0-rc1 /cc @carlossanlop @sbomer Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
This is currently blocking the arcade dependency flow PR for RC1: #90665 |
carlossanlop
added
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsBackport of #90449 to release/8.0-rc1 /cc @carlossanlop @sbomer Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
carlossanlop
added
Servicing-consider
|
Test-only change. |
Backport of #90449 to release/8.0-rc1
/cc @carlossanlop @sbomer
Customer Impact
No known impact. This fixes test bugs that were exposed by an update to a new SDK. The fix is relevant for internal testing purposes but does not reflect a customer scenario.
Testing
This fixes test issues that were fixed in main, but not in rc1.
Risk
Very low risk. No change to product behavior.